-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nil_values
instead of null_character
in IO operations
#667
Merged
josevalim
merged 3 commits into
elixir-explorer:main
from
cnpryer:null-character-default
Jul 28, 2023
Merged
Use nil_values
instead of null_character
in IO operations
#667
josevalim
merged 3 commits into
elixir-explorer:main
from
cnpryer:null-character-default
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnpryer
commented
Jul 27, 2023
philss
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to me 👍
I added some suggestions.
cnpryer
force-pushed
the
null-character-default
branch
from
July 27, 2023 12:29
8960882
to
f9b34bb
Compare
cnpryer
changed the title
Use
Use Jul 27, 2023
nil
for null_character
default in IO operationsnil_values
instead of null_character
in IO operations
cnpryer
commented
Jul 27, 2023
I didn't use "nil" in Rust since I figured it's Elixir-specific (I'm very new to Elixir). I can change that as well if you'd like. |
josevalim
reviewed
Jul 27, 2023
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #666
UpdatesSee #667 (comment)null_character
defaults used in csv reading operations to usenil
instead of"NA"
.Updates usage of
null_character
tonull_values
allowing multiple missing value interpretation in IO operations. This also changes the default from "NA" tonil
.Result: