Enables alternative correlation methods #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 12, 2023
lib/explorer/data_frame.ex
Outdated
| @@ -5678,6 +5678,9 @@ defmodule Explorer.DataFrame do | |||
| * `:column_name` - the name of the column with column names. Defaults to "names". | |||
| * `:ddof` - the 'delta degrees of freedom' - the divisor used in the correlation | |||
| calculation. Defaults to 1. | |||
| * `method` refers to the correlation method. The following methods are available: | |||
There was a problem hiding this comment.
Suggested change
| * `method` refers to the correlation method. The following methods are available: | |
| * `:method` refers to the correlation method. The following methods are available: |
|
Looks great but indeed atoms will be better. I think you need to declare an enum in Rust. Ask @philss, he will know for sure! |
cristineguadelupe
force-pushed
the
cg-correlation-methods
branch
from
3c1fe6a
to
9950d1d
Compare
cristineguadelupe
force-pushed
the
cg-correlation-methods
branch
from
9950d1d
to
091b324
Compare
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm passing the correlation method as string to follow the
Series.rankconvention but I'd suggest to use atoms instead. WDYT?