Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor eager DF implementation to make use of lazy backend #893

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Refactor eager DF implementation to make use of lazy backend #893

merged 1 commit into from
Apr 12, 2024

Conversation

philss
Copy link
Member

@philss philss commented Apr 11, 2024

The idea is to have less code to maintain.

@philss
Refactor eager DF implementation to make use of lazy backend
b58622f 
The idea is to have less code to maintain.
josevalim
josevalim approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a glorious commit

@cigrainger
Copy link
Member

This is absolutely beautiful.

@philss philss merged commit c3ad65a into main Apr 12, 2024
4 checks passed
@philss philss deleted the ps-refactor-eager-to-use-lazy branch April 12, 2024 13:15
@philss
Copy link
Member Author

philss commented Apr 12, 2024

Thank you, guys! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philss @cigrainger @josevalim