-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial SQL support #918
Initial SQL support #918
Conversation
i say "quasi" because we also want to allow mutate(df, a: sql("max(a)"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! 🚀
I added some minor points :)
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com>
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billylanchantin this is looking great! Is my understanding correct that we have two features in this pull request? One is to write SQL at the root level and another is to embed SQL inside mutate? Can I propose for us to add only the first one for now and then evolve it from there?
@josevalim I'm good with that! Any particular hesitation with the embedded SQL part? Or are you just favoring smaller changes since this is experimental? |
let's see if we can get this right in one go...
Just favoring something smaller for now. It is always easier to add stuff than to remove them. :) |
Description
This PR experiments with initial SQL support by adding
Explorer.DataFrame.sql/3
for making SQL queries against dataframes.Example
Limitations