-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Duplicates for Singular and Plural Messages and provide merge command #120
Conversation
Pull Request Test Coverage Report for Build 039d97de88269db33836787606e08f7bfd50a81c-PR-120
💛 - Coveralls |
fd231cd
to
47e234c
Compare
377ff8d
to
50c59c7
Compare
50c59c7
to
2439ea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started to review this but I stopped because I'd like to first understand if we already have logic for merging messages (I thought we did).
Also, one more thing: let's not use single-letter variables please 🙃 msg1
/msg2
goes a long way over a
/b
.
6ee7314
to
039d97d
Compare
@maennchen all makes sense, let's just update the Mix task and lmk when this is ready for another pass of reviewing 💯 |
039d97d
to
1fdeb5a
Compare
🎉 |
Part of elixir-gettext/gettext#366
Hold off merging until a PR of
gettext
itself is merged that provides a migration path.