Fix compose output of extracted comments on plural messages
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for extracted comments and plural messages Two test failures as of this commit: - compose/2 plural message with extracted comments - compose/2 plural message with both comments and extracted comments
Correct `compose` output of extracted comments on plural messages
|
Good catch, thank you @mthiems! 💟 |
whatyouhide
approved these changes
Mar 26, 2024
whatyouhide
changed the title
compose output of extracted comments on plural messagescompose output of extracted comments on plural messages
Pull Request Test Coverage Report for Build f718fbda496c281f0e0c559f113575d049e8cebb-PR-133Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
38 doctests, 349 tests, 0 failuresI've also verified that this addresses the issues I am having with
gettext.extractandgettext.mergewhen there are extracted comments on plural messages in .pot/.po files (as mentioned in #132).