Update Elixir/Erlang in CI and deps #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build e1c2afef516fa37afd3341ef8aa10530c1dc90f0-PR-137Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 0260422d37ecb77ac91a129d242cbe046f31153c-PR-137Details
💛 - Coveralls |
maennchen
reviewed
Jun 12, 2024
.github/workflows/part_test.yml
Outdated
| elixir: '1.16' | ||
| runs-on: ubuntu-latest | ||
| - otp: '26.2' | ||
| - otp: '27.0' |
There was a problem hiding this comment.
Do you not want to test on the latest stable release?
There was a problem hiding this comment.
This is the latest stable release, no?
There was a problem hiding this comment.
I wouldn’t consider elixir main stable.
There was a problem hiding this comment.
I don't know, main was there before, I thought you added it and so I left it there 😄 I don't think it's necessary to test main no, latest stable (1.17) is enough.
There was a problem hiding this comment.
I usually include elixir main as a way to detect issues with new elixir releases. (More for the stability of elixir itself than the respective project.
Based on this i would test:
- Lowest stable OTP / Elixir supported
- Latest stable OTP / Elixir
- Elixir main
|
Credo CI failure cause: rrrene/credo#1139 |
|
Credo published a fix that should solve the CI failure. |
Pull Request Test Coverage Report for Build 8f590a9d244e5b68e9c0b716cbd85fa23fb0bb75-PR-137Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 13678f2844733d9cc342063dc4c78f8508ffcccb-PR-137Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.