-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Elixir/Erlang in CI and deps #137
Conversation
Pull Request Test Coverage Report for Build e1c2afef516fa37afd3341ef8aa10530c1dc90f0-PR-137Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 0260422d37ecb77ac91a129d242cbe046f31153c-PR-137Details
💛 - Coveralls |
.github/workflows/part_test.yml
Outdated
elixir: '1.16' | ||
runs-on: ubuntu-latest | ||
- otp: '26.2' | ||
- otp: '27.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you not want to test on the latest stable release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest stable release, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn’t consider elixir main stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, main
was there before, I thought you added it and so I left it there 😄 I don't think it's necessary to test main
no, latest stable (1.17) is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually include elixir main as a way to detect issues with new elixir releases. (More for the stability of elixir itself than the respective project.
Based on this i would test:
- Lowest stable OTP / Elixir supported
- Latest stable OTP / Elixir
- Elixir main
Credo CI failure cause: rrrene/credo#1139 |
Credo published a fix that should solve the CI failure. |
Pull Request Test Coverage Report for Build 8f590a9d244e5b68e9c0b716cbd85fa23fb0bb75-PR-137Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 13678f2844733d9cc342063dc4c78f8508ffcccb-PR-137Details
💛 - Coveralls |
No description provided.