Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly Escape backslashes in PO Composer #139

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Correctly Escape backslashes in PO Composer #139

merged 1 commit into from
Aug 22, 2024

Conversation

maennchen
Copy link
Member

Fixes #138

@maennchen maennchen added the bug Something isn't working label Aug 22, 2024
@maennchen maennchen requested a review from whatyouhide August 22, 2024 16:25
@maennchen maennchen self-assigned this Aug 22, 2024
@coveralls
Copy link

coveralls commented Aug 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 90e1521efb659943f0f2598ff0a716be22913437-PR-139

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.144%
Totals Coverage Status
Change from base Build cbf1170021483a5707da9f127973d1d69b258b25: 0.0%
Covered Lines: 423
Relevant Lines: 431
💛 - Coveralls

@whatyouhide whatyouhide merged commit 5f1dbaf into main Aug 22, 2024
8 checks passed
@whatyouhide whatyouhide deleted the escape_backslash branch August 22, 2024 17:07
@whatyouhide
Copy link
Contributor

Nice, thanks @maennchen! 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees

@maennchen maennchen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not escaping backslashes properly, creating invalid files
3 participants
@maennchen @coveralls @whatyouhide