Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user if conflicting plural messages are defined #401

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Warn user if conflicting plural messages are defined #401

merged 1 commit into from
Nov 13, 2024

Conversation

maennchen
Copy link
Member

Fixes #400

@maennchen maennchen self-assigned this Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 0ff41505c6f3cc6ed03eb1dcdd79779f83adb53b-PR-401

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.884%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/gettext/extractor_agent.ex 11 13 84.62%
Totals Coverage Status
Change from base Build b41445ea04da137c62fb7ebc822fd8f05f2353fa: -0.1%
Covered Lines: 634
Relevant Lines: 690
💛 - Coveralls

whatyouhide
whatyouhide reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work.

lib/gettext/extractor_agent.ex Outdated Show resolved Hide resolved
lib/gettext/extractor_agent.ex Outdated Show resolved Hide resolved
lib/gettext/extractor_agent.ex Outdated Show resolved Hide resolved
@maennchen maennchen force-pushed the jm/conflicting_plural_message_400 branch from 70a3410 to c9fccb1 Compare November 13, 2024 12:24
@maennchen maennchen force-pushed the jm/conflicting_plural_message_400 branch from c9fccb1 to a65fe29 Compare November 13, 2024 12:28
@maennchen maennchen force-pushed the jm/conflicting_plural_message_400 branch from a65fe29 to 0ff4150 Compare November 13, 2024 12:30
whatyouhide
whatyouhide approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If we use Logger in other places too then this is good to go.

lib/gettext/extractor_agent.ex Show resolved Hide resolved
@maennchen maennchen merged commit 528e9cb into main Nov 13, 2024
3 checks passed
@maennchen maennchen deleted the jm/conflicting_plural_message_400 branch November 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees

@maennchen maennchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error on conflicting plural messages
3 participants
@maennchen @coveralls @whatyouhide