Handle blank Mix target values properly #11603
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses whitespace or empty string accidentally passed into
Mix.target/1
.Changes
Mix.target/1
accept a string valueMix.target/1
handle whitespace properlyNotes
Mix.target/1
, which is error-prone. For example,:""
can sneak in easily.Mix.target/1
accepting a string is that we can standardize on converting a string Mix target value to atom properly.Mix.target()
is:""
for ElixirLS nerves-project/nerves#694