Update case.ex with correct :since for register_test/6
#13642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while addressing the `ExUnit.Case.register_test/3` deprecation in elixir-wallaby/wallaby#776, I wondered how long `register_test/6` had been around. In looking at the source and the docs, I uncovered what I believe is an incorrect `since` attribute
vanderhoop
commented
Jun 6, 2024
| @@ -578,7 +578,7 @@ defmodule ExUnit.Case do | |||
| display. You can use `ExUnit.plural_rule/2` to set a custom | |||
| pluralization. | |||
| """ | |||
| @doc since: "1.10.0" | |||
| @doc since: "1.11.0" | |||
There was a problem hiding this comment.
I initially looked through this file's history by version tag to check this. It would have been faster had I just searched the changelogs 😄
https://github.com/elixir-lang/elixir/blob/v1.11/CHANGELOG.md#exunit-1
whatyouhide
approved these changes
Jun 6, 2024
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jun 6, 2024
while addressing the `ExUnit.Case.register_test/3` deprecation in elixir-wallaby/wallaby#776, I wondered how long `register_test/6` had been around. In looking at the source and the docs, I uncovered what I believe is an incorrect `since` attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while addressing the
ExUnit.Case.register_test/3deprecation in elixir-wallaby/wallaby#776, I wondered how longregister_test/6had been around. In looking at the source and the docs, I uncovered what I believe is an incorrectsinceattribute