fix: prevent unreadable text when using inline code with admonition headers #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaders * Some cases of using inline code in admonition headers like light theme and errors or night theme and warnings would cause make the code be too bland (gray) for the white background. Forcing the inline code tag color black when showing in the admonition header seems to fix it.
|
💚 💙 💜 💛 ❤️ |
pmargreff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While navigating on
ex_unitusing Hex, I found some styling issues when using inline code inside admonition header blocks. Check the bottom of this page using dark mode. Not sure if it was added when adding support to admonition (#1400) or while removing less (#1597).The problem happened when using inline code in admonition headers for some specific combinations, like the light theme and "errors" or the night theme and "warnings". Which would make the code to be too unreadable (gray font for the white background).
I'm following the same pattern for inline code that shows up in the admonition body, forcing the inline code tag color to be black. Examples of cases happening before and after the change above:
Before (light theme)
After (light theme)
Before (dark theme)
After (dark theme)
I'm almost sure these changes would require generating assets. But once
mix buildchanges a lot of things, I am not confident about which generated files I should commit.