Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping #{} in search_items.json #1728

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix escaping #{} in search_items.json #1728

merged 1 commit into from
Jul 4, 2023

Conversation

wojtekmach
Copy link
Member

Inspect implementation for String is such that:

iex> ~S"#{}"
"\#{}"

However \# is invalid JSON escape code.

@wojtekmach
Fix escaping #{} in search_items.json
895fa25 
Inspect implementation for String is such that:

    iex> ~S"#{}"
    "\#{}"

However `\#` is invalid JSON escape code.
@wojtekmach wojtekmach requested a review from josevalim July 4, 2023 11:24
@wojtekmach wojtekmach merged commit d617f9e into main Jul 4, 2023
3 checks passed
@wojtekmach wojtekmach deleted the wm-escape branch July 4, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekmach @josevalim