Fix requestMessage doesnt seem to match spec #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelson
reviewed
Feb 23, 2020
axelson
reviewed
Feb 23, 2020
Add a shutdown test with params and without params
axelson
reviewed
Feb 23, 2020
fix formatting
axelson
added a commit
that referenced
this pull request
Feb 23, 2020
bfolkens
deleted the
elixir-lsp/138_fix_requestMessage_doesnt_seem_to_match_spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the LSP spec for requestMessage, the params key is optional. However, the code seems to only expect the 3 arity variant. This patch allows both the 2 arity and 3 arity variants, so that the shutdown requests will work (which doesn't include a params key).
Fixes #138
See also:
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#requestMessage