Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debugger was inadvertently broken in #93 which the change from the deprecated ([2])
Code.load_file/1
toCode.require_file/1
. The compatibility docs for 1.10 [1] list bothCode.require_file/1
andCode.compile_file/1
as possible replacements forCode.load_file/1
. In our case we needCode.compile_file/1
instead ofCode.require_file/1
sinceCode.require_file/1
tracks which files have been required and compiled and does not compile them more than once. Specifically the docs state:So since
Code.load_file/1
would always compile the file we need to useCode.compile_file/1
rather thanCode.require_file/1
. WhenCode.require_file/1
was used, the call inElixirLS.Debugger.Server.change_env/1
would have no effect because the file was previously required. By changing toCode.compile_file/1
the project will always be reloaded by compiling it'smix.exs
file.[1] https://hexdocs.pm/elixir/1.10.2/compatibility-and-deprecations.html#table-of-deprecations
[2] elixir-lang/elixir#7201
Fixes #131