Remove function argument snippets if snippets unsupported #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffrey-xiao
force-pushed
the
fix-snippets-supported
branch
2 times, most recently
from
cabded3 to
41f8e64
Compare
|
If this approach of passing options down to snippet looks good, I'll add tests. |
jeffrey-xiao
force-pushed
the
fix-snippets-supported
branch
from
41f8e64 to
08520b5
Compare
axelson
reviewed
Apr 26, 2020
apps/language_server/lib/language_server/providers/completion.ex
Outdated
Show resolved
Hide resolved
jeffrey-xiao
force-pushed
the
fix-snippets-supported
branch
from
08520b5 to
93c43ad
Compare
…#207) Prior to this change, function completion always filled in function arguments with snippets. If snippets are not supported by the client, do not fill in any arguments, but only complete the name of the function. Additionally, tweak the snippet regex to recognize ${1:arg1} as a snippet.
jeffrey-xiao
force-pushed
the
fix-snippets-supported
branch
from
93c43ad to
3a9c525
Compare
axelson
added a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, function completion always filled in function arguments with snippets. If snippets are not supported by the client, do not fill in any arguments, but only complete the name of the function.
Additionally, tweak the snippet regex to recognize ${1:arg1} as a snippet.
Fixes #207.