Create .gitignore before trigger build #232
Conversation
| :ok <- File.write(gitignore_path, "*", [:read]) do | ||
| state | ||
| else | ||
| _ -> state |
There was a problem hiding this comment.
I'm not sure what should we do when have a problems while creating a file.
There was a problem hiding this comment.
I think just logging a warning is good (using JsonRpc.log_message(:warning, message))
| :ok <- File.write(gitignore_path, "*", [:read]) do | ||
| state | ||
| else | ||
| _ -> state |
There was a problem hiding this comment.
I think just logging a warning is good (using JsonRpc.log_message(:warning, message))
| defp create_gitignore(%{project_dir: project_dir} = state) do | ||
| with gitignore_path <- Path.join([project_dir, ".elixir_ls", ".gitignore"]), | ||
| :ok <- gitignore_path |> Path.dirname() |> File.mkdir_p(), | ||
| :ok <- File.write(gitignore_path, "*", [:read]) do |
There was a problem hiding this comment.
Why use :read here? Wouldn't :write make more sense?
There was a problem hiding this comment.
You're right. This should be :write
|
@axelson your suggestion was addressed. please kindly review. |
|
I see test failed in dialyzer. Not sure why it happens. https://travis-ci.org/github/elixir-lsp/elixir-ls/jobs/684546804 |
| state | ||
| else | ||
| true -> | ||
| JsonRpc.log_message(:warning, ".elixir_ls/.gitignore already exists") |
There was a problem hiding this comment.
Since this is an expected case, we don't need this log message.
|
I'm pretty sure that dialyzer error is spurious and unrelated. |
Create a .gitignore file by using project_dir in server state before trigger build to make sure it create in the right place. Close elixir-lsp#206
|
@wingyplus yeah, thanks for taking the time to do this, it’ll be one less thing newcomers will have to deal with. |
|
Thanks for you both. I learned a lot from this pr. |
Create a .gitignore file by using project_dir in server state before
trigger build to make sure it create in the right place.
Close #206