Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop OTP 20 and add version support guidance #337

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Drop OTP 20 and add version support guidance #337

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e27c74c
Drop OTP 20 and add version support guidance
axelson Aug 2, 2020
5fb5fc8
Add PR # to changelog
axelson Aug 2, 2020
962b0e4
Change minimum Elixir version to 1.8.0
axelson Aug 4, 2020
7d867be
update changelog
axelson Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
#
# The versions selected here are the versions that are used to build a binary
# release for distribution
elixir 1.7.4-otp-20
erlang 20.3.8.23
elixir 1.7.4-otp-21
erlang 21.3.8.17
4 changes: 1 addition & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@ cache:
- _build
matrix:
include:
- otp_release: 20.3
elixir: 1.7.4
- otp_release: 21.3
elixir: 1.8.2
elixir: 1.7.4
- otp_release: 22.3
elixir: 1.9.4
- otp_release: 23.0
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Potentially breaking changes:
- Do not format files that are not listed in `inputs` of `.formatter.exs` (thanks [Tan Jay Jun](https://github.com/jayjun)) [#315](https://github.com/elixir-lsp/elixir-ls/pull/315)
- Drop OTP 20 support and set some version support guidelines (thanks [Jason Axelson](https://github.com/axelson)) [PR #337](https://github.com/elixir-lsp/elixir-ls/pull/337)

Improvements:
- Add Ecto completion plugin from ElixirSense (thanks [Marlus Saraiva](https://github.com/msaraiva)) [#333](https://github.com/elixir-lsp/elixir-ls/pull/333)
Expand Down
10 changes: 10 additions & 0 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# Version Support Guidelines

Elixir itself supports 5 versions with security updates:
https://hexdocs.pm/elixir/compatibility-and-deprecations.html#content

OTP Supports the last 3 versions:
http://erlang.2086793.n4.nabble.com/OTP-Versions-and-Maint-Branches-td4722416.html

ElixirLS supports the last 4 versions of Elixir and the last 3 versions of OTP. However this is not a hard and fast rule and may change in the future.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we could aim for 3 last versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, after thinking about it some more I agree. I think this will help us focus more on stability (by reducing the number of supported configurations)


# Packaging

Bump the changelog
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Elixir:

Erlang:

- OTP 20 minimum
- OTP 21 minimum

You may want to install Elixir and Erlang from source, using the [kiex](https://github.com/taylor/kiex) and [kerl](https://github.com/kerl/kerl) tools. This will let you go-to-definition for core Elixir and Erlang modules.

Expand Down