-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto publish release with asset #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It would be very helpful to have this part of the release process automated. We definitely need to change the versions used to build the release, but that's the only major change needed.
Co-authored-by: Jason Axelson <axelson@users.noreply.github.com>
it's automatically detected by the setup action from the otp version
Let me know if there is anything you want changed. |
ping @axelson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good ❤️
The maintainer no longer needs to build the release manually. elixir-lsp#384
When a tag is pushed, this automatically builds the asset, creates a draft release on the tag, and upload the asset to the release.
You can then modify the release description and publish.
Feel free to close if it's unwanted.
I used it in my own fork while debugging the formatting issue on Windows. https://github.com/princemaple/elixir-ls/releases