Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto publish release with asset #384

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

princemaple
Copy link
Contributor

@princemaple princemaple commented Oct 13, 2020

When a tag is pushed, this automatically builds the asset, creates a draft release on the tag, and upload the asset to the release.
You can then modify the release description and publish.

Feel free to close if it's unwanted.
I used it in my own fork while debugging the formatting issue on Windows. https://github.com/princemaple/elixir-ls/releases

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It would be very helpful to have this part of the release process automated. We definitely need to change the versions used to build the release, but that's the only major change needed.

.github/workflows/release-asset.yml Outdated Show resolved Hide resolved
.github/workflows/release-asset.yml Outdated Show resolved Hide resolved
Co-authored-by: Jason Axelson <axelson@users.noreply.github.com>
@princemaple princemaple requested a review from axelson October 13, 2020 20:23
it's automatically detected by the setup action from the otp version
@princemaple
Copy link
Contributor Author

Added multi version build
image

@princemaple
Copy link
Contributor Author

princemaple commented Oct 13, 2020

Added a default build that is just elixir 1.8.2 to match prior behavior.
image

@princemaple
Copy link
Contributor Author

Let me know if there is anything you want changed.

@princemaple
Copy link
Contributor Author

ping @axelson

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good ❤️

@axelson axelson merged commit a1b43b4 into elixir-lsp:master Oct 23, 2020
axelson added a commit that referenced this pull request Oct 23, 2020
@princemaple princemaple deleted the auto-release branch October 24, 2020 05:58
axelson added a commit to axelson/elixir-ls that referenced this pull request Nov 16, 2020
The maintainer no longer needs to build the release manually.
elixir-lsp#384
lukaszsamson pushed a commit that referenced this pull request Nov 22, 2020
The maintainer no longer needs to build the release manually.
#384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants