Autocompletion: more specific CompletionItemKind #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning module for all types of modules, return "interface" for behaviours and protocols, and "struct" for structs. Also add the subtype to the label
| case subtype do | ||
| :behaviour -> :interface | ||
| :protocol -> :interface | ||
| :struct -> :struct |
There was a problem hiding this comment.
Exception as a struct?
is there sth for mix task?
There was a problem hiding this comment.
Yeah, it makes sense to return exception as a struct. I don't see anything that would map well to mix tasks, so I think it makes sense to leave it as a module.
|
Nice! |
|
Okay, test has been fixed and added a case to handle exceptions as structs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning module for all types of modules, return "interface" for behaviours and protocols, and "struct" for structs.
Also add the subtype to the label
This is what the completions look like before:
This is what they look like after:
