Fix suggest contracts windows regression #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on windows we need to convert from "c:\\some\\other.ex" to "c:/some/other.ex" Fixes #528
axelson
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Do you understand what caused this regression? We haven't touched this portion of the code in a while. And it's not like we upgraded dialyxir either.
I'm also thinking we should create SourceFile.abs_path_from_uri since we're calling Path.absname on the output so often.
|
I guess it worked on Windows purely by chance and got broken when I did the URI parsing refactoring and fixes.
Good idea. Besides that we'd need some test coverage on suggest specs. I'll add those in this PR later. |
vanjabucic
pushed a commit
to vanjabucic/elixir-ls
that referenced
this pull request
Jul 5, 2021
* Dialyzer.suggest_contracts expects absnames on windows we need to convert from "c:\\some\\other.ex" to "c:/some/other.ex" Fixes elixir-lsp#528 * fix test on windows * add suggest contracts tests * apply code review suggestion * revert non windows compatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.