-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docsite publish #636
Fix docsite publish #636
Conversation
@DaniruKun Thanks for this! Can you temporarily cause this to run on every PR? I want ensure the site gets built and I don't want to make another tag just to get the site built and deployed. Once it is built and deployed we can change it back to run only on tags and then merge this PR. |
8f66b6c
to
9b545dd
Compare
@axelson please make sure the |
9b545dd
to
5c3f801
Compare
29bb44c
to
99b228e
Compare
.github/workflows/docsite.yml
Outdated
with: | ||
branch: mkdocs | ||
folder: site | ||
token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by the documentation the token shouldn't need to be passed directly, so we should be okay if we just remove this line.
token: ${{ secrets.GITHUB_TOKEN }} |
99b228e
to
3fb2ceb
Compare
Okay, in #640 I've deployed the initial version of the site 🎉 |
@axelson so no changes are needed in the workflow file, apart from trigger on new tag push on master? |
@DaniruKun yes that's correct, but it should be built when there's a tag, not from pushes to master. The issue is that the build previously was being triggered from a PR, where the branch that backed the PR was from a fork, which meant that the token associated with the PR did not have the appropriate permissions. Now that we'll be triggering the workflow from a tag that shouldn't be an issue. |
Okay, I changed it to build on tags in 00b7dde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! ❤️
This PR fixes the docsite publishing, which was previously missing uploading and downloading of the docsite static files artefact.