Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide completions for protocol functions #83

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Provide completions for protocol functions #83

merged 2 commits into from
Dec 6, 2019

Conversation

lukaszsamson
Copy link
Collaborator

@lukaszsamson lukaszsamson commented Dec 4, 2019 •
edited
Loading

Addresses #40

axelson
axelson requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good but can we change the test to not rely on a built-in elixir module? This would involve creating a defprotocol that is compiled in the test env (similar to what is done in ElixirSense)

axelson
axelson approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

@axelson axelson merged commit 9ad535f into elixir-lsp:master Dec 6, 2019
@lukaszsamson lukaszsamson mentioned this pull request Jan 17, 2020
Closed
@lukaszsamson lukaszsamson deleted the ls-complete-protocol-funs branch April 15, 2020 08:04
axelson added a commit that referenced this pull request Apr 28, 2020
@axelson
Update changelog for vscode PR #83
ff1103c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asummers asummers asummers approved these changes

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsamson @axelson @asummers