Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test lenses): Use single instead of double quotes non-Windows environments and escape nested quotes #175

Merged

Conversation

Blond11516
Copy link
Contributor

Fixes elixir-lsp/elixir-ls#485 and part of elixir-lsp/elixir-ls#438.

Use single quotes in non-windows environments to escape bash special characters. Also escapes nested single quotes.

@axelson axelson force-pushed the fix/unescaped_special_characters branch from 5d5e443 to 9aa6627 Compare February 27, 2021 18:49
@axelson axelson force-pushed the fix/unescaped_special_characters branch from 9aa6627 to 2500443 Compare February 27, 2021 18:55
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ❤️

@axelson axelson merged commit 155db28 into elixir-lsp:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test lens doesn't escape test name properly
2 participants