Fix dialyzer issues #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build af9b5676d8bec085b57fa93016ce833474eeb7b7-PR-23
💛 - Coveralls |
|
This has been taken care of in #27 so I will close this out, but thank you for your PR! |
|
Sorry I couldn't get back to this, but that's for resolving! @the-mikedavis |
Pull Request Test Coverage Report for Build af9b5676d8bec085b57fa93016ce833474eeb7b7-PR-23Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build af9b5676d8bec085b57fa93016ce833474eeb7b7-PR-23Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great project! I originally heard about it on your episode of Thinking Elixir.
I pulled
Mint.WebSocketinto my project, and found a bunch of dialyzer issues. This PR aims to address all of the dialyzer issues, as well as adding to CI.