Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bumblebee.Utils.Nx.to_list/1 in favour of Nx.to_list/1 #319

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Remove Bumblebee.Utils.Nx.to_list/1 in favour of Nx.to_list/1 #319

merged 2 commits into from
Dec 19, 2023

Conversation

thiagopromano
Copy link
Contributor

After Nx.to_list/1 (elixir-nx/nx#1095) was added, the function Bumblebee.Utils.Nx.to_list became redundant.

jonatanklosko
jonatanklosko approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonatanklosko jonatanklosko changed the title Deprecate Bumblebee.Utils.Nx.to_list/1 Remove Bumblebee.Utils.Nx.to_list/1 in favour of Nx.to_list/1 Dec 19, 2023
@jonatanklosko jonatanklosko merged commit bb00641 into elixir-nx:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagopromano @jonatanklosko