Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally include cuda or rocm #30

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conditionally include cuda or rocm #30

merged 2 commits into from
Dec 14, 2022

Conversation

seanmor5
Copy link
Contributor

@seanmor5 seanmor5 commented Dec 11, 2022 •
edited
Loading

No description provided.

@seanmor5
Copy link
Contributor Author

We should probably also include a ROCm build-target

This shouldn't be merged until we bump the TF Git Rev (probably for TF 2.12)

@jonatanklosko
Copy link
Member

We should probably also include a ROCm build-target

You mean we should precompile?

@seanmor5
Copy link
Contributor Author

This is a half-fix for #29 but we still need to bump the Git rev to officially close that. But in the meantime this should do :)

@seanmor5 seanmor5 merged commit 256dd7a into main Dec 14, 2022
@seanmor5 seanmor5 deleted the fix-rocm branch December 14, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmor5 @jonatanklosko