Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging Globo.com Timeout middle for Tesla #119

Merged
merged 4 commits into from
Oct 6, 2017
Merged

Merging Globo.com Timeout middle for Tesla #119

merged 4 commits into from
Oct 6, 2017

Conversation

emerleite
Copy link
Contributor

As proposed here: https://github.com/globocom/tesla_timeout/issues/3

If you have any improvements to ask, please tell us, so we can do it and merge.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 97.052% when pulling d4414d0 on globocom:master into f5eaf9b on teamon:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 97.052% when pulling d4414d0 on globocom:master into f5eaf9b on teamon:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 97.052% when pulling d4414d0 on globocom:master into f5eaf9b on teamon:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 97.052% when pulling d4414d0 on globocom:master into f5eaf9b on teamon:master.

@teamon
Copy link
Member

teamon commented Oct 6, 2017

Coool :)
Please take a look at failing tests at https://travis-ci.org/teamon/tesla/builds/284008138

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 98.034% when pulling 835295e on globocom:master into f5eaf9b on teamon:master.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 98.034% when pulling dfeb7c5 on globocom:master into f5eaf9b on teamon:master.

@emerleite
Copy link
Contributor Author

@teamon We just increased the coverage and did a fix to Elixir 1.3 compatibility, but one test failed due HEX timeout. Can you run then again?

@teamon teamon merged commit d9349ea into elixir-tesla:master Oct 6, 2017
@amatalai amatalai mentioned this pull request Oct 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emerleite @coveralls @teamon