Global mock support #143
Merged
Global mock support #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 98.3% 98.32% +0.02%
==========================================
Files 21 21
Lines 412 418 +6
==========================================
+ Hits 405 411 +6
Misses 7 7
Continue to review full report at Codecov.
|
zorbash
reviewed
Dec 7, 2017
lib/tesla/mock.ex
Outdated
| @doc """ | ||
| Setup global mocks. | ||
|
|
||
| **WARNING**: This mock will be available to ALL process. |
zorbash
reviewed
Dec 7, 2017
lib/tesla/mock.ex
Outdated
|
|
||
| While this style is recommended, there is one drawback: | ||
| if Tesla client is called from different process then the | ||
| test case it will not get proper mock. |
There was a problem hiding this comment.
I suggest a minor rewording to:
If Tesla client is called from a different process then the test case will not be mocked.
There was a problem hiding this comment.
The test case process itself will be mocked. Either way, both messages would be wrong ;)
It should be something like this "if Tesla client is called from different process it will not use the setup mock"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #136, also related to #140
I've moved setting up global mock into separate function to be explicit about it. It will also fail fast when used inappropriately with async test cases.
@zorbash, @amatalai please take a look.
@gottfrois, @pawelduda, @Daniel-Xu please try using tesla from
global-mockbranch and let us know if there are any issues.