feat!: change Readability and Consistency diagnostic severity to hint (…

…#47)
elixir-tools · Jun 6, 2023 · 060763e · 060763e
1 parent a1b289f
commit 060763e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/credo_language_server.ex b/lib/credo_language_server.ex
@@ -382,8 +382,12 @@ defmodule CredoLanguageServer do
   defp category_to_severity(:refactor), do: DiagnosticSeverity.error()
   defp category_to_severity(:warning), do: DiagnosticSeverity.warning()
   defp category_to_severity(:design), do: DiagnosticSeverity.information()
-  defp category_to_severity(:consistency), do: DiagnosticSeverity.hint()
-  defp category_to_severity(:readability), do: DiagnosticSeverity.hint()
+
+  defp category_to_severity(:consistency),
+    do: DiagnosticSeverity.information()
+
+  defp category_to_severity(:readability),
+    do: DiagnosticSeverity.information()
 
   defp wait_until(cb) do
     wait_until(120, cb)

diff --git a/test/credo_language_server_test.exs b/test/credo_language_server_test.exs
@@ -145,7 +145,7 @@ defmodule CredoLanguageServerTest do
       assert_notification "textDocument/publishDiagnostics",
                           %{
                             "uri" => ^uri,
-                            "diagnostics" => [%{"severity" => 4}]
+                            "diagnostics" => [%{"severity" => 3}]
                           }
     end
 
@@ -160,8 +160,8 @@ defmodule CredoLanguageServerTest do
                         %{
                           "uri" => ^uri,
                           "diagnostics" => [
-                            %{"severity" => 4},
-                            %{"severity" => 4}
+                            %{"severity" => 3},
+                            %{"severity" => 3}
                           ]
                         }
 
@@ -197,8 +197,8 @@ defmodule CredoLanguageServerTest do
                         }
 
     [
-      %{"severity" => 4} = diagnostic,
-      %{"severity" => 4}
+      %{"severity" => 3} = diagnostic,
+      %{"severity" => 3}
     ] = Enum.sort(diagnostics)
 
     assert :ok ==
@@ -307,8 +307,8 @@ defmodule CredoLanguageServerTest do
              })
 
     [
-      %{"severity" => 4},
-      %{"severity" => 4} = diagnostic
+      %{"severity" => 3},
+      %{"severity" => 3} = diagnostic
     ] = Enum.sort(diagnostics)
 
     assert :ok ==