Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation for window related functions #629

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

mhanberg
Copy link
Member

Also fixes #628

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #629 (4b523ec) into main (8120d9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          24       24           
  Lines         941      941           
=======================================
  Hits          866      866           
  Misses         75       75           
Flag Coverage Δ
IntegrationTest 87.67% <ø> (ø)
UnitTest 41.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/wallaby/browser.ex 94.50% <ø> (ø)
lib/wallaby/helpers/key_codes.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8120d9a...4b523ec. Read the comment docs.

@mhanberg
Copy link
Member Author

@rrrene really sorry to bother you, but do you have any idea why i'd be getting these Credo errors? https://github.com/elixir-wallaby/wallaby/pull/629/checks?check_run_id=3617265849

I am sort of at a loss 😅.

(Feel free to ignore this if you don't have free time. I wanted to avoid opening an issue as I can't imagine this is a bug in credo)

@rrrene
Copy link

rrrene commented Sep 17, 2021

@mhanberg It's a Credo bug. Thx for reporting this. Working on a minimal reproducible example.

@mhanberg mhanberg merged commit 7dc994b into main Sep 23, 2021
@mhanberg mhanberg deleted the mh/doc-improvement-1 branch September 23, 2021 00:49
@rrrene
Copy link

rrrene commented Sep 23, 2021

@mhanberg Thanks for reporting this 😀 It is now fixed on master.

Could you try this again by setting your Credo dep to

{:credo, github: "rrrene/credo"}

Please report back if your issue is solved! 👍

@mhanberg
Copy link
Member Author

@rrrene I opened another PR to trial the credo updates #630.

Looks like there are still a few false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Wallaby.Session.t() typespec is private
3 participants