Improve failure wording #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 92.60% 92.62% +0.02%
==========================================
Files 24 24
Lines 919 922 +3
==========================================
+ Hits 851 854 +3
Misses 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
marcandre
added a commit
to marcandre/wallaby
that referenced
this pull request
Oct 7, 2021
It distinguishes three cases about the id specified by the "for" attribute: * does not exist * exists once (but must be failing because of a type mismatch) * exists multiple times [Fixes elixir-wallaby#634]
This extends "but only <n>" wording to all cases were <n> is smaller than expected. It fixes the case where expected was 0 and result was 1 from "Expected 0 but only 1 was found"
|
Thank you! 🎃 |
mhanberg
pushed a commit
to marcandre/wallaby
that referenced
this pull request
Oct 20, 2021
It distinguishes three cases about the id specified by the "for" attribute: * does not exist * exists once (but must be failing because of a type mismatch) * exists multiple times [Fixes elixir-wallaby#634]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes commas that were grammatically incorrect
Second commit extends "Expected ... but only ... were found" to any
nthat is smaller than expected value (not justn == 1).It also fixes the case were expected was 0 and 1 element was found. It used to say "Expected 0 but only 1 was found", now the "only" is no longer there.