Remove dead code #635
Remove dead code #635
Conversation
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
===========================================
- Coverage 92.62% 62.03% -30.59%
===========================================
Files 24 24
Lines 922 922
===========================================
- Hits 854 572 -282
- Misses 68 350 +282
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mhanberg
force-pushed
the
remove_dead_code
branch
from
eb74b27 to
ecd92c6
Compare
| |> Keyword.put_new(:count, opts[:count]) | ||
| |> Keyword.put_new(:minimum, opts[:minimum]) | ||
| |> Keyword.put_new(:maximum, opts[:maximum]) | ||
| |> Keyword.put_new(:count, nil) | ||
| |> Keyword.put_new(:minimum, nil) | ||
| |> Keyword.put_new(:maximum, nil) |
There was a problem hiding this comment.
I'm not sure this is correct.
This branch is reached if one of those three options is not nil, meaning, 2 of them could have a value.
With this change, they are always set to nil.
There was a problem hiding this comment.
Right, but it's put_new, not put.
any_map |> Keyword.put_new(:any_key, any_map[:any_key])
# always equivalent to
any_map |> Keyword.put_new(:any_key, nil)
mhanberg
force-pushed
the
remove_dead_code
branch
from
ecd92c6 to
e5ccfd2
Compare
No description provided.