Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages #645

Merged
merged 4 commits into from
May 7, 2022
Merged

Fix error messages #645

merged 4 commits into from
May 7, 2022

Conversation

marcandre
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #645 (c0f9315) into main (5e02d94) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

❗ Current head c0f9315 differs from pull request most recent head 9371f8f. Consider uploading reports for the commit 9371f8f to get more accurate results

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   88.04%   87.31%   -0.73%     
==========================================
  Files          24       24              
  Lines         995      930      -65     
==========================================
- Hits          876      812      -64     
+ Misses        119      118       -1     
Flag Coverage Δ
IntegrationTest 80.75% <50.00%> (-0.46%) ⬇️
UnitTest 41.50% <100.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/wallaby/query/error_message.ex 87.27% <100.00%> (ø)
lib/wallaby/feature.ex 72.00% <0.00%> (-2.08%) ⬇️
lib/wallaby/driver/log_store.ex 80.00% <0.00%> (-1.82%) ⬇️
lib/event_emitter.ex 90.00% <0.00%> (-1.67%) ⬇️
lib/wallaby/selenium.ex 16.04% <0.00%> (-1.03%) ⬇️
lib/wallaby/element.ex 74.28% <0.00%> (-0.72%) ⬇️
lib/wallaby/query.ex 98.07% <0.00%> (-0.39%) ⬇️
lib/wallaby/chrome.ex 96.15% <0.00%> (-0.15%) ⬇️
lib/wallaby/webdriver_client.ex 99.36% <0.00%> (-0.04%) ⬇️
lib/wallaby.ex 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da789b3...9371f8f. Read the comment docs.

@marcandre
Copy link
Contributor Author

Includes #644 so CI passes

@mhanberg mhanberg merged commit 0a41983 into elixir-wallaby:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants