fix(chromedriver): Account for Chromium when doing the version matching

[mhanberg]

We weren't accounting for Chromium when checking the versions of Chrome and ChromeDriver were matching.

@michallepicki can you install this branch and see if it fixes the problem? I was able to confirm that it works with Chromium locally on my MacBook, but haven't tested it manually for Chromium on Linux.

Thanks

Fixes #697 (maybe)

[conceivably]

As far as I can tell, I had the same problem with Chromium on Linux on the Wallaby main branch, in that I got:

** (MatchError) no match of right hand side value: {:error, {:wallaby, {:bad_return, {{Wallaby, :start, [:normal, []]}, {:EXIT, {%Wallaby.DependencyError{message: "Wallaby can't find Chrome. Make sure you have chrome installed and included in your path.\nYou can also provide a path using `config :wallaby, :chromedriver, binary: <path>`.\n"}, [{Wallaby, :start, 2, [file: 'lib/wallaby.ex', line: 33, error_info: %{module: Exception}]}, {:application_master, :start_it_old, 4, [file: 'application_master.erl', line: 293]}]}}}}}}
    test/test_helper.exs:4: (file)
    (elixir 1.13.1) lib/code.ex:1183: Code.require_file/2
    (elixir 1.13.1) lib/enum.ex:937: Enum."-each/2-lists^foreach/1-0-"/2

With this branch the problem disappears for me 👍
Thank you for the fix :)

[mhanberg]

@conceivably im not sure that it matters but are you running this locally or just CI?

[jfpedroza]

I would like to add that in Alpine Linux the Chromium binary is called chromium-browser instead of chromium. This branch fixes it for me locally, but not for Docker (used both locally and on CI).

[mhanberg]

@johnf9896 would you be able to provide me with the docker file that demonstrates the failure?

[jfpedroza]

I guess I could create a simple project for it but I think the problem can be solved by adding "chromium-browser" to ["google-chrome", "chromium"]. Everything works if I specify the path manually, otherwise I get the same error as @conceivably.

[mhanberg]

@johnf9896 Turns out that I had just missed that name when I was looking through the chromedriver codebase for the list of binary locations that it will look for. chromium-browser was there.

I pushed up another commit that adds that name.

[jfpedroza]

That indeed solves it :)

[mhanberg]

Thanks for all the help folks.

This seems like it's fixed, but I'll wait for @michallepicki to confirm.

[michallepicki]

this branch starts Chromium for me as well, thanks