-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Elixir 1.17 warnings #561
Conversation
Nice one, before we proceed with this one, can you please add CI for elixir 17 as a separate PR. Cheers. |
Some tests are breaking with Elixir 1.16 and Elixir 1.17, similar to the issue blocking tests with OTP 26 |
@ypconstante it would be good to see it before fixing, as main is green. |
Done #562 |
Thank you @ypconstante! |
@ypconstante thank you for the fixes! @igas would it be possible to cut a release with the elixir 1.17 warning fixes? I would prefer to rely on the official hex package than pointing here on the github repo. Thank you in advance! 🙏 |
@igas / @anthonator (👋🏼) just checking in on this, would you be able to cut a new release that contains this fix please? 🙏🏼 |
It would be awesome if a new release could be done to reduce the amount of warnings generated at compile time 🙏 Thanks!! |
This fixes some of the warnings being logged when using Elixir 1.17
~c
There are still some warnings because of pattern matching on ranges, but fixing this requires an API change or bumping the minimum Elixir version to 1.12 to be able to match or ignore the range step.
Closes #558
I've added: