Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.17 warnings #561

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Conversation

ypconstante
Copy link
Contributor

This fixes some of the warnings being logged when using Elixir 1.17

  • Fix compilation warnings caused by single quote usages. In some places I changed to double quotes, in others to ~c
  • Fix runtime warning on Faker.random_uniform/0 caused by missing parenthesis in function call

There are still some warnings because of pattern matching on ranges, but fixing this requires an API change or bumping the minimum Elixir version to 1.12 to be able to match or ignore the range step.

Closes #558

I've added:

  • USAGE.md docs if applicable
  • CHANGELOG.md

@igas
Copy link
Member

igas commented Jun 6, 2024

Nice one, before we proceed with this one, can you please add CI for elixir 17 as a separate PR. Cheers.

@ypconstante
Copy link
Contributor Author

Some tests are breaking with Elixir 1.16 and Elixir 1.17, similar to the issue blocking tests with OTP 26

@igas
Copy link
Member

igas commented Jun 6, 2024

@ypconstante it would be good to see it before fixing, as main is green.

@ypconstante
Copy link
Contributor Author

Done #562

@igas igas enabled auto-merge (squash) June 15, 2024 03:49
@igas
Copy link
Member

igas commented Jun 15, 2024

Thank you @ypconstante!

@igas igas merged commit 6611ba4 into elixirs:master Jun 15, 2024
15 checks passed
@seantanly
Copy link

@ypconstante thank you for the fixes!

@igas would it be possible to cut a release with the elixir 1.17 warning fixes? I would prefer to rely on the official hex package than pointing here on the github repo. Thank you in advance! 🙏

@ypconstante ypconstante deleted the fix-elixir-1.17-warnings branch June 24, 2024 03:16
@dkarter
Copy link

dkarter commented Aug 13, 2024

@igas / @anthonator (👋🏼) just checking in on this, would you be able to cut a new release that contains this fix please? 🙏🏼

@odarriba
Copy link

It would be awesome if a new release could be done to reduce the amount of warnings generated at compile time 🙏

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile warnings with Elixir 1.17 rc
5 participants