-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests compatible with Elixir 1.16 and 1.17 #565
Open
ypconstante
wants to merge
75
commits into
elixirs:master
Choose a base branch
from
ypconstante:tests-compatible-elixir-1.17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make tests compatible with Elixir 1.16 and 1.17 #565
ypconstante
wants to merge
75
commits into
elixirs:master
from
ypconstante:tests-compatible-elixir-1.17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
igas
force-pushed
the
tests-compatible-elixir-1.17
branch
from
September 11, 2024 04:03
50cd093
to
aa41dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usages of Elixir functions that return random data, allowing us to update the test to work on all supported Elixir versions:
Enum.random
with:rand.uniform
onFaker.Random.Test.random_between
Enum.random
withrandom_between
onFaker.Random.Test.random_bytes
Enum.take_random
andEnum.shuffle
withEnum.sort_by(random_uniform)
After this changes the only tests breaking was on
Faker.File
because of the map ordering changes on OTP 26, also fixed it and updated CI to test on both OTP 26 and 27.I've added: