Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly aesthetic changes, fixed some wonky bullets and numbered lists. #2698

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

bealers
Copy link
Contributor

@bealers bealers commented Jan 23, 2025

Relates to

Documentation

Risks

Low

What does this PR do?

  • Provide aesthetic tweaks (some wonky bullets and structure)
  • Add some minor clarifications
  • Update for newer characters

What kind of change is this?

Improvements (misc. changes to existing features)

Documentation changes needed?

N/A

Testing

None: Automated tests are acceptable.

Discord username

@bealers

Summary by CodeRabbit

  • Documentation
    • Updated quickstart guide with improved installation instructions
    • Enhanced prerequisites section with nvm recommendation
    • Added "Cursor" to recommended code editors
    • Clarified environment configuration and agent setup steps
    • Improved overall document readability and structure

Copy link
Contributor

coderabbitai bot commented Jan 23, 2025

Walkthrough

The pull request updates the quickstart.md documentation for the Eliza project, focusing on improving installation and setup instructions. The changes include recommending nvm for Node.js version management, expanding code editor suggestions, simplifying repository setup commands, and clarifying environment configuration and agent creation steps. The modifications aim to enhance user comprehension and provide more precise guidance for project setup.

Changes

File Change Summary
docs/docs/quickstart.md - Added nvm recommendation for Node.js management
- Expanded code editor list to include "Cursor"
- Simplified repository cloning and setup instructions
- Improved environment configuration formatting
- Clarified agent creation and character loading process

Possibly related PRs

Poem

🚀 Docs refined with care and might,
Eliza's path now shining bright
Quickstart guide, no longer maze
Clarity blooms in coding days!
📘✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bealers! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!

@wtfsayo
Copy link
Member

wtfsayo commented Jan 23, 2025

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Jan 23, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (7)
docs/docs/quickstart.md (7)

11-14: Specify minimum Node.js version more precisely

Change "Node.js 23+" to "Node.js 23.3.0+" to match the version mentioned in the Common Issues section.


75-79: Add missing comma in the opening sentence

Add a comma before "and": "Eliza supports multiple AI models, and you set which model to use inside the character JSON file."

🧰 Tools
🪛 LanguageTool

[uncategorized] ~75-~75: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Model Eliza supports multiple AI models and you set which model to use inside the c...

(COMMA_COMPOUND_SENTENCE)


92-102: Remove trailing colons from headings

Change:

  • "For llama_local inference:" to "For llama_local inference"
  • "For Ollama inference:" to "For Ollama inference"
🧰 Tools
🪛 Markdownlint (0.37.0)

92-92: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


99-99: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


106-116: Use proper heading structure

Replace bold text with proper markdown heading:

-**Create a Character File**
+### Create a Character File
🧰 Tools
🪛 LanguageTool

[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)

🪛 Markdownlint (0.37.0)

106-106: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


238-244: Add language specifiers to code blocks

Add appropriate language specifiers to fenced code blocks:

-```
+```plaintext
 triggerUncaughtException(
-```
+```bash
 # Add dependencies to workspace root
-```
+```plaintext
 Error starting agents: Error: The module

Also applies to: 248-269, 274-279

🧰 Tools
🪛 Markdownlint (0.37.0)

238-238: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


108-109: Add missing comma after 'Additionally'

Add a comma: "Additionally, you can read packages/core/src/defaultCharacter.ts."

🧰 Tools
🪛 LanguageTool

[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)


63-71: Add security warning for API keys

Add a warning about keeping API keys secure and never committing them to version control.

 # Suggested quickstart environment variables
+# SECURITY WARNING: Keep these API keys secure and never commit them to version control
 DISCORD_APPLICATION_ID=  # For Discord integration
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02518fa and a32fd07.

📒 Files selected for processing (1)
  • docs/docs/quickstart.md (3 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/docs/quickstart.md

[uncategorized] ~75-~75: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Model Eliza supports multiple AI models and you set which model to use inside the c...

(COMMA_COMPOUND_SENTENCE)


[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)

🪛 Markdownlint (0.37.0)
docs/docs/quickstart.md

92-92: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


99-99: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


106-106: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


118-118: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


132-132: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


238-238: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


248-248: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


274-274: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: integration-tests

@wtfsayo wtfsayo merged commit 34ebf70 into elizaOS:develop Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants