-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly aesthetic changes, fixed some wonky bullets and numbered lists. #2698
Mostly aesthetic changes, fixed some wonky bullets and numbered lists. #2698
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bealers! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
docs/docs/quickstart.md (7)
11-14
: Specify minimum Node.js version more preciselyChange "Node.js 23+" to "Node.js 23.3.0+" to match the version mentioned in the Common Issues section.
75-79
: Add missing comma in the opening sentenceAdd a comma before "and": "Eliza supports multiple AI models, and you set which model to use inside the character JSON file."
🧰 Tools
🪛 LanguageTool
[uncategorized] ~75-~75: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Model Eliza supports multiple AI models and you set which model to use inside the c...(COMMA_COMPOUND_SENTENCE)
92-102
: Remove trailing colons from headingsChange:
- "For llama_local inference:" to "For llama_local inference"
- "For Ollama inference:" to "For Ollama inference"
🧰 Tools
🪛 Markdownlint (0.37.0)
92-92: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
99-99: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
106-116
: Use proper heading structureReplace bold text with proper markdown heading:
-**Create a Character File** +### Create a Character File🧰 Tools
🪛 LanguageTool
[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
🪛 Markdownlint (0.37.0)
106-106: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
238-244
: Add language specifiers to code blocksAdd appropriate language specifiers to fenced code blocks:
-``` +```plaintext triggerUncaughtException(-``` +```bash # Add dependencies to workspace root-``` +```plaintext Error starting agents: Error: The moduleAlso applies to: 248-269, 274-279
🧰 Tools
🪛 Markdownlint (0.37.0)
238-238: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
108-109
: Add missing comma after 'Additionally'Add a comma: "Additionally, you can read
packages/core/src/defaultCharacter.ts
."🧰 Tools
🪛 LanguageTool
[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
63-71
: Add security warning for API keysAdd a warning about keeping API keys secure and never committing them to version control.
# Suggested quickstart environment variables +# SECURITY WARNING: Keep these API keys secure and never commit them to version control DISCORD_APPLICATION_ID= # For Discord integration
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docs/quickstart.md
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/docs/quickstart.md
[uncategorized] ~75-~75: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Model Eliza supports multiple AI models and you set which model to use inside the c...
(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~108-~108: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ...a number of character files to try out. Additionally you can read `packages/core/src/default...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
🪛 Markdownlint (0.37.0)
docs/docs/quickstart.md
92-92: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
99-99: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
106-106: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
118-118: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
132-132: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
238-238: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
248-248: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
274-274: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: integration-tests
Relates to
Documentation
Risks
Low
What does this PR do?
What kind of change is this?
Improvements (misc. changes to existing features)
Documentation changes needed?
N/A
Testing
None: Automated tests are acceptable.
Discord username
@bealers
Summary by CodeRabbit
nvm
recommendation