Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ts-node with tsx on @ai16z/agent - fix #288 #292

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

metadiver
Copy link
Contributor

replace ts-node with tsx on @ai16z/agent

Relates to:

Issue #288

Risks

Low – This change impacts only the TypeScript execution environment by replacing ts-node with tsx, improving compatibility without affecting core functionality.

Background

What does this PR do?

  • Replaces ts-node with tsx to provide better support for handling .ts files within the Node.js environment.

What kind of change is this?

  • Bug fixes (non-breaking change that fixes an issue).

Why are we doing this? Any context or related work?

Replacing ts-node with tsx resolves an issue with pnpm start failing due to .ts file handling issues in this environment setup.

Documentation changes needed?

  • My changes require a change to the project documentation.
  • I have updated the documentation accordingly.

Testing

Where should a reviewer start?

Start by verifying the setup instructions and running pnpm start to confirm the fix.

Detailed testing steps

  1. Install dependencies with pnpm i.
  2. Run pnpm start.
  3. Confirm that the application starts without errors.

replace ts-node with tsx on @ai16z/agent
@leomercier leomercier changed the base branch from main to upgrade/tsx November 13, 2024 17:27
@leomercier
Copy link
Collaborator

Screenshot 2024-11-13 at 17 27 12

Could not pull down to test so created new branch

@metadiver
Copy link
Contributor Author

this is the right path https://github.com/metadiver/eliza.git

@leomercier
Copy link
Collaborator

Screenshot 2024-11-13 at 17 32 05

Still no working

add back start command to @ai16z/eliza removed on d49f4c9
@metadiver
Copy link
Contributor Author

metadiver commented Nov 13, 2024

it worked for me previously because i run 'pnpm build' before 'pnpm start'.

some code was removed from core causing this issue with; 'pnpm start'
d49f4c9#diff-f0f4adde46deb8e106c88cfb5dbf48155b8261ff0d73ada3429381a40e9bb3baR12

I have added the code back here and works fine without 'pnpm build'
e2d483e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants