Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intial set up #12

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Intial set up #12

merged 2 commits into from
Oct 9, 2023

Conversation

Antoine-Aube
Copy link
Collaborator

Description

Please include a description of what was changed:

  1. Data base set up - Three tables migrated, potential for a fourth with movies still being up in the air. Might be a table or consumed directly from the API

  2. Gems installed and set up - Simplecov, Shoulda Matchers

Type of change

  • fix
  • feat
  • test
  • refactor
  • [ x] docs

Checklist

  • code has been self reviewed
  • code runs without any errors
  • thorough testing has been implemented if adding feature
  • all tests pass

Thanks!

Copy link
Owner

@elizakeating elizakeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did this together so it all looks good.

@elizakeating elizakeating merged commit d81dad4 into main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants