Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix updates #314

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

nix updates #314

wants to merge 4 commits into from

Conversation

sheepforce
Copy link
Contributor

This Nix PR adds the compiled pysisyphus addons with sympleints, adds thermoanalysis module, the missing numba and optuna dependencies, and forces usage of ORCA 5.0.4 instead of the current 6.0.1 release.

@sheepforce sheepforce changed the base branch from master to dev November 7, 2024 12:28
@sheepforce sheepforce force-pushed the nix branch 2 times, most recently from 1641592 to 80628db Compare November 25, 2024 12:43
@sheepforce
Copy link
Contributor Author

@eljost the test_diabatization_driver[DiaKind.EDMISTON_RUEDENBERG] and test_diabatization_driver[DiaKind.BOYS] are still failing, now with file not found errors. Looks like the others that had problems with gitignore.

@eljost
Copy link
Owner

eljost commented Nov 27, 2024

The required files are now mentioned explicitly in .gitignore. It seems as if the wildcard(s) in .gitignore don't work.

@sheepforce
Copy link
Contributor Author

1 solved, 1 to go, still a missing file:

pysisyphus> =================================== FAILURES ===================================
pysisyphus> ____________ test_diabatization_driver[DiaKind.EDMISTON_RUEDENBERG] ____________
pysisyphus> 
pysisyphus> dia_kinds = <DiaKind.EDMISTON_RUEDENBERG: 1>
pysisyphus> this_dir = PosixPath('/build/ffpjvwb1cwdarpjcaz9nxsnjbhzy74v4-source/tests/test_diabatization')
pysisyphus> 
pysisyphus>     @pytest.mark.parametrize(
pysisyphus>         "dia_kinds",
pysisyphus>         (
pysisyphus>             pytest.param(
pysisyphus>                 dia_driver.DiaKind.EDMISTON_RUEDENBERG, marks=using("pysisyphus_addons")
pysisyphus>             ),
pysisyphus>             (dia_driver.DiaKind.BOYS),
pysisyphus>         ),
pysisyphus>     )
pysisyphus>     def test_diabatization_driver(dia_kinds, this_dir):
pysisyphus>         """Example from http://dx.doi.org/10.1063/1.3148777 (BeNa2 cation)."""
pysisyphus>         inp_dir = this_dir / "00_bena2_cat"
pysisyphus>         out_dir = this_dir / "00_bena2_cat_out"
pysisyphus>         base = inp_dir / "00_bena2_dcat.log"
pysisyphus>         base_name = base.stem
pysisyphus>         wf, all_ens, Xa, Ya, Xb, Yb = dia_driver.parse_orca(base)
pysisyphus>         states = [1, 2]
pysisyphus>     
pysisyphus>         dia_inp = dia_driver.DiaInput(
pysisyphus>             wf=wf,
pysisyphus>             all_ens=all_ens,
pysisyphus>             Xa=Xa,
pysisyphus>             Ya=Ya,
pysisyphus>             Xb=Xb,
pysisyphus>             Yb=Yb,
pysisyphus>             states=states,
pysisyphus>             base_name=base_name,
pysisyphus>         )
pysisyphus>         # Update states by calculating overlaps if requested
pysisyphus> >       dia_results, cube_fns = dia_driver.run_dia(
pysisyphus>             dia_inp,
pysisyphus>             dia_kinds=dia_kinds,
pysisyphus>             cube_kinds=dia_driver.CubeKind.NONE,
pysisyphus>             out_dir=out_dir,
pysisyphus>             force=True,
pysisyphus>             h5_fn=out_dir / "00_bena2_cat_dia_result.h5",
pysisyphus>         )
pysisyphus> 
pysisyphus> tests/test_diabatization/test_diabatization.py:48: 
pysisyphus> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pysisyphus> /nix/store/h3i0acpmr8mrjx07519xxmidv8mpax4y-python3-3.12.5/lib/python3.12/functools.py:907: in wrapper
pysisyphus>     return dispatch(args[0].__class__)(*args, **kw)
pysisyphus> pysisyphus/diabatization/driver.py:970: in _
pysisyphus>     return run_dia(
pysisyphus> /nix/store/h3i0acpmr8mrjx07519xxmidv8mpax4y-python3-3.12.5/lib/python3.12/functools.py:907: in wrapper
pysisyphus>     return dispatch(args[0].__class__)(*args, **kw)
pysisyphus> pysisyphus/diabatization/driver.py:853: in run_dia
pysisyphus>     er_dia_result = run_coulomb_dia(
pysisyphus> pysisyphus/diabatization/driver.py:414: in run_coulomb_dia
pysisyphus>     aux_shells = shells.from_basis(aux_basis_fn)
pysisyphus> pysisyphus/wavefunction/shells.py:463: in from_basis
pysisyphus>     return shells_with_basis(
pysisyphus> /nix/store/h3i0acpmr8mrjx07519xxmidv8mpax4y-python3-3.12.5/lib/python3.12/functools.py:907: in wrapper
pysisyphus>     return dispatch(args[0].__class__)(*args, **kw)
pysisyphus> pysisyphus/wavefunction/Basis.py:182: in shells_with_basis
pysisyphus>     basis = basis_from_json(name)
pysisyphus> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pysisyphus> 
pysisyphus> name = 'def2-universal-jfit.json'
pysisyphus> 
pysisyphus>     def basis_from_json(name):
pysisyphus>         basis_path = Path(name).with_suffix(".json")
pysisyphus>         if not basis_path.is_absolute():
pysisyphus>             basis_path = BASIS_LIB_DIR / basis_path
pysisyphus>     
pysisyphus> >       with open(basis_path) as handle:
pysisyphus> E       FileNotFoundError: [Errno 2] No such file or directory: '/build/ffpjvwb1cwdarpjcaz9nxsnjbhzy74v4-source/pysisyphus/basis_library/def2-universal-jfit.json'
pysisyphus> 
pysisyphus> pysisyphus/wavefunction/Basis.py:22: FileNotFoundError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants