Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed opening links in the browser #25

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

piotrski
Copy link
Member

Ref: #21

@stackblitz
Copy link

stackblitz bot commented Jan 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@JonasKruckenberg
Copy link
Collaborator

ah nice elk already has target="_blank" for external links, that's handy 👍🏻 should just work on any OS as-is

@JonasKruckenberg
Copy link
Collaborator

can you go ahead and add a change file in the .changes folder too?

The basic format (also documented the in the readme of that folder) is as follows:

---
"elk": patch or minor or major
---

A description of your change

@piotrski
Copy link
Member Author

All links have target="_blank", but they do not work without this change.
image

Perhaps we should add information about .changes to the readme. BTW is there a reason we are not just using conventional commits like elk?

@piotrski
Copy link
Member Author

What should be the name of the .md file? I see you are using covector is there cli fot that like for changeset

@JonasKruckenberg
Copy link
Collaborator

JonasKruckenberg commented Jan 17, 2023

Perhaps we should add information about .changes to the readme. BTW is there a reason we are not just using conventional commits like elk?

It's a really recent change so I haven't had time to update anything yet (I got the workflow fixed literally only minutes ago).
The basic reasoning is that change files are freeform and lend themselves much better to end-user facing Changelogs than the more low-level conventional-commits based wokflow

What should be the name of the .md file? I see you are using covector is there cli fot that like for changeset

No CLI command for that yet, but maybe that changes in a few days 👀 you can call the file whatever you want

Copy link
Collaborator

@JonasKruckenberg JonasKruckenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JonasKruckenberg JonasKruckenberg merged commit 068037a into elk-zone:main Jan 17, 2023
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
@piotrski
Copy link
Member Author

@JonasKruckenberg we forgot to update the elk submodule, because the issue needed changes in both it was fixes here elk-zone/elk#1268

@JonasKruckenberg
Copy link
Collaborator

let's update to at least the title-bar dragging PRs commit, can you open a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants