Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent default event when hide dropdown #1282

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

webfansplz
Copy link
Member

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@stackblitz
Copy link

stackblitz bot commented Jan 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit d354dda
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c797dd088b5100086b7a7e

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d354dda
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c797dd584308000833f85d
😎 Deploy Preview https://deploy-preview-1282--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

@Akryum this seems to be a feature everyone would need, are we missing something in the way we use VDropdown? @webfansplz I wonder if we should better upstream this feature if this is not yet supported

@webfansplz
Copy link
Member Author

webfansplz commented Jan 18, 2023

@Akryum this seems to be a feature everyone would need, are we missing something in the way we use VDropdown? @webfansplz I wonder if we should better upstream this feature if this is not yet supported

I've been thinking about it, but I'm not sure if it's within the scope of VDropdown. /cc @Akryum

I read some of the UI components framework documentation about dropdown,no one seems to support this either.So I wonder if this is beyond the definition of dropdown component itself.

@Akryum
Copy link
Contributor

Akryum commented Jan 18, 2023

It could totally be an option in floating-vue.

@webfansplz webfansplz marked this pull request as draft January 19, 2023 01:05
@Shinigami92 Shinigami92 added the c: bug Something isn't working label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants