Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show background color for direct post to reduce mistake #2732

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 1, 2024

resolves #2723

Screenshots

Screenshot from 2024-03-31 18-18-35

Also, it properly expands the background when it has many lines:
Screenshot from 2024-03-31 18-22-17

Copy link

stackblitz bot commented Apr 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c302469
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/660a2b139cf2650008056750

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c302469
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/660a2b137d0c3d00088c69a3
😎 Deploy Preview https://deploy-preview-2732--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this was such an important missing piece 🙌🏼

@patak-dev patak-dev added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit 5064b26 Apr 1, 2024
19 checks passed
@patak-dev patak-dev deleted the shuuji3/feat/show-direct-post-background-color branch April 1, 2024 05:28
@patak-dev
Copy link
Member

Trying to see why the elkdev user doesn't work locally for me 🤔
In the meantime, after using this for a bit, the styles in this PR are good for the main editor. I was thinking if we should have a bit of gradient to avoid the feeling of going to send a bunch of empty lines.

image

There is also some missing bottom padding for the reply editor in threads

image

And the same missing bottom padding in both the main and thread editors when it reached the expansion point

image

@shuuji3
Copy link
Member Author

shuuji3 commented Apr 3, 2024

Good point.👍🏻 If the message is a single line, I think the background should be the same height as the posted message. And, the bottom margin/padding seems to be less than the top one. I'll adjust this unbalanced padding/margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show background color when sending "Direct" message
2 participants