Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error form.dataset.show undefined #109

Closed
gizmothecat opened this issue Apr 24, 2024 · 3 comments
Closed

Javascript error form.dataset.show undefined #109

gizmothecat opened this issue Apr 24, 2024 · 3 comments

Comments

@gizmothecat
Copy link

Trying the plugin for the first time on a craft 5 install and it doesn't display the default bottom modal as expected.
I never tried the plugin before and I tried it on a craft 4 install and it works as expected.

I get that javascript error :
Screenshot 2024-04-24 at 21 13 06

Any ideas?

Thanks

@gizmothecat gizmothecat changed the title Javascript error windows undefined Javascript error form.dataset.show undefined Apr 24, 2024
@jellingsen
Copy link
Contributor

Hi @gizmothecat

I'm unable to reproduce. Are you using a custom template for the banner?

@gizmothecat
Copy link
Author

I have been able to resolve the problem. But I have found an Yii error when you delete a cookie group it sends you to a page that doesn't exist.

jellingsen added a commit that referenced this issue May 2, 2024
* Updated version and changelog

* Fixed redirect after cookie group deletion

* Update composer.lock for dependabot scans

---------

Co-authored-by: Jørgen Ellingsen <jorgenellingsen@Jrgen-sin-MacBook-Pro.local>
Co-authored-by: DDEV User <nobody@example.com>
@jellingsen
Copy link
Contributor

Thank you for reporting it.
Redirect after cookie group deletion now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants