Improve EvalString
#113
Merged
Improve EvalString
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make several improvements and fixes to `EvalString`.
* Change the member variable to store the last text segment length (or
0 if the last section is a variable). This keeps things more
understandable and doesn't lose any functionality.
* Remove the initial `Offset` value pushed into `EvalString` in the
constructor and `clear()` methods as this is not necessary.
* Assert that text and variables passed in are not empty and check
that this cannot happen (the Ninja lexer will complain that the
file is not correct)
* Add a natvis file for easy debugging.
elliotgoodrich
force-pushed
the
simplify-evalstring
branch
from
f402a7a to
4482a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make several improvements and fixes to
EvalString.Offsetvalue pushed intoEvalStringin the constructor andclear()methods as this is not necessary.