Fix absolute/relative path handling in --affected
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional was incorrectly reversed due to my misreading of `std::error_code` so we never attempted to look up the absolute or relative path for paths passed in to `--affected`. It was a bit tricky to do unit test for absolute paths as they need to be generated beforehand. This commit is less lazy and includes unit tests for absolute and relative path handling by generating files in the CMake generation step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional was incorrectly reversed due to my misreading of
std::error_codeso we never attempted to look up the absolute or relative path for paths passed in to--affected.It was a bit tricky to do unit test for absolute paths as they need to be generated beforehand. This commit is less lazy and includes unit tests for absolute and relative path handling by generating files in the CMake generation step.