Rewrite EvalString
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgoodrich
force-pushed
the
improve-evalstring
branch
2 times, most recently
from
5b56671 to
b949f96
Compare
Create a new `EvalString` that performs better.
In particular:
* it is more cache friendly, having only one allocation of contiguous
memory
* it retaings all capacity when clearing, meaning the `EvalString` we
reuse in `ManifestParser` will allocate a lot less
* `evaluate` removes some `if`s since we know variables always follow
text
elliotgoodrich
force-pushed
the
improve-evalstring
branch
from
b949f96 to
3798d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
EvalStringthat performs better.In particular:
EvalStringwe reuse inManifestParserwill allocate a lot lessevaluateremoves someifs since we know variables always follow text