Swap to boost::unordered_flat_map
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgoodrich
force-pushed
the
boost_unordered
branch
2 times, most recently
from
b1ecb4c to
ccaa11c
Compare
The performance of `std::unordered_map` is widely known to be sub-optimal due to the requirement for iterator and reference stability. This precludes An up-to-date benchmark can be found here: https://jacksonallan.github.io/c_cpp_hash_tables_benchmark, which shows that `boost::unordered_flat_map` performs extremely well for inserts and lookups, which is all we do. The lack of iteration speed, the erasure residual performance impact, and the minimum capacity of 30 all have no affect on us. The `boost::unordered_flat_map` implementation has been taken from https://github.com/MikePopoloski/boost_unordered. Add more implementation to `fixed_string` as we now need to be move-constructible and move-assignable since we will be moved around inside `boost::unordered_flat_map`. Add `SYSTEM` to the include path for `thirdparty` so we don't get warnings on external code.
elliotgoodrich
force-pushed
the
boost_unordered
branch
from
ccaa11c to
753aab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance of
std::unordered_mapis widely known to be sub-optimal due to the requirement for iterator and reference stability. This precludesAn up-to-date benchmark can be found here:
https://jacksonallan.github.io/c_cpp_hash_tables_benchmark, which shows that
boost::unordered_flat_mapperforms extremely well for inserts and lookups, which is all we do. The lack of iteration speed, the erasure residual performance impact, and the minimum capacity of 30 all have no affect on us.The
boost::unordered_flat_mapimplementation has been taken from https://github.com/MikePopoloski/boost_unordered.