Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change @namespace and add @annotation highlight #193

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

mikesmithgh
Copy link
Contributor

I am running Neovim with nvim-jdtls for LSP support in my Java development. When I have the LSP client attached, I noticed the imports statement syntax highlighting looked off.

See screenshot below (Left is @namespace Include and Right is @namespace GruvboxFg1)
Screenshot 2022-12-26 at 12 12 36 AM

I sampled a couple colorschemes: everforest, github_dark, and rosepine. It seems like @namespace is normally mapped to the same highlight as @variable or @variable.builtin. I just personally liked the look of @variable more so I mapped it to GruvboxFg1. For annotation I mapped it to Operator so it would have the same coloring as the @ symbol.

'@namespace' and '@annotation' appear to be coming from the language server: https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/semantictokens/TokenType.java

Please let me know if you need any additional info. Enjoying the coloscheme in Lua 🙂

@ellisonleao ellisonleao merged commit e863942 into ellisonleao:main Jan 4, 2023
@ellisonleao
Copy link
Owner

thanks @mikesmithgh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants